Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cgen: fix different option alias type as fn arg #23131

Merged
merged 3 commits into from
Dec 11, 2024
Merged

cgen: fix different option alias type as fn arg #23131

merged 3 commits into from
Dec 11, 2024

Conversation

felipensp
Copy link
Member

@felipensp felipensp commented Dec 11, 2024 •
edited by huly-for-github bot
Loading

spytheman
spytheman approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@spytheman spytheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work.

@spytheman spytheman marked this pull request as ready for review December 11, 2024 14:06
@spytheman
Copy link
Member

I think the remaining CI job is very unlikely to fail, given the nature of the fix.

@spytheman spytheman merged commit 77e4594 into vlang:master Dec 11, 2024
72 checks passed
@felipensp felipensp deleted the fix_option_alias_arg_diff branch December 11, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spytheman spytheman spytheman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

invalid c code generation with generics, options and type aliases
2 participants
@felipensp @spytheman