Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cgen: fix update expr with embed fixed array multi dimensions #23049

Merged
merged 1 commit into from
Dec 3, 2024
Merged

cgen: fix update expr with embed fixed array multi dimensions #23049

merged 1 commit into from
Dec 3, 2024

Conversation

felipensp
Copy link
Member

@felipensp felipensp commented Dec 2, 2024 •
edited by huly-for-github bot
Loading

@felipensp felipensp marked this pull request as ready for review December 2, 2024 13:56
Delta456
Delta456 approved these changes Dec 2, 2024
View reviewed changes
Copy link
Member

@Delta456 Delta456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work

spytheman
spytheman approved these changes Dec 3, 2024
View reviewed changes
Copy link
Member

@spytheman spytheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work.
I liked the reduction of code, by extracting the common case into a function very much.

@spytheman spytheman merged commit d3b5dbd into vlang:master Dec 3, 2024
72 checks passed
@felipensp felipensp deleted the fix_array_fixed_2_dims_embed branch December 4, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spytheman spytheman spytheman approved these changes

@Delta456 Delta456 Delta456 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cloning heap struct instance with spread operator creates invalid copy.
3 participants
@felipensp @spytheman @Delta456