Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

builder: fix msvc build thirdparty obj file from .cpp #22789

Merged
merged 3 commits into from
Nov 8, 2024
Merged

builder: fix msvc build thirdparty obj file from .cpp #22789

merged 3 commits into from
Nov 8, 2024

Conversation

felipensp
Copy link
Member

@felipensp felipensp commented Nov 7, 2024 •
edited by huly-for-github bot
Loading

@felipensp felipensp marked this pull request as ready for review November 7, 2024 14:29
@spytheman
Copy link
Member

Please comment/remove it in cmd/tools/modules/testing/common.v:229:skip_files if it is fixed.

@spytheman spytheman merged commit 43d9cd6 into vlang:master Nov 8, 2024
71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

vlib:MSVC C++ Test Failing
2 participants
@felipensp @spytheman