Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v: fix interface conversion codegen race issue #22655

Merged
merged 1 commit into from
Oct 26, 2024
Merged

v: fix interface conversion codegen race issue #22655

merged 1 commit into from
Oct 26, 2024

Conversation

felipensp
Copy link
Member

@felipensp felipensp commented Oct 26, 2024 •
edited
Loading

This PR fixes the race issue about reading/writing on interface info.conversions map reffered by @medvednikov on PR #22640

Probably related to #17943

My test was:
for i in $(seq 1 50); do v ui/examples/users.v && echo "Success compilation" ; done

Huly®: V_0.6-21104

@felipensp felipensp marked this pull request as ready for review October 26, 2024 03:55
spytheman
spytheman approved these changes Oct 26, 2024
View reviewed changes
Copy link
Member

@spytheman spytheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work.

@spytheman spytheman merged commit 067c5b6 into vlang:master Oct 26, 2024
78 checks passed
@spytheman spytheman mentioned this pull request Oct 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spytheman spytheman spytheman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@felipensp @spytheman