Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ANSI pathname under windows #22395

Closed
wants to merge 1 commit into from

Conversation

kbkpbot
Copy link
Contributor

@kbkpbot kbkpbot commented Oct 3, 2024

fix #21502

This PR will make compile non-English pathname/filename under Windows possible.
For example:

v D:\测试目录\测试.v
测试.exe

@kbkpbot
Copy link
Contributor Author

kbkpbot commented Oct 3, 2024

Should encoding.iconv support a special encoding LOCAL? This encoding will be 'ANSI' under Windows, and 'UTF-8' under Linux.

This will simplify some codes.

@JalonSolov
Copy link
Contributor

I think a common name would be good, so you don't have to add the extra logic to decide based on the target OS when you compile.

@kbkpbot kbkpbot closed this Oct 3, 2024
@kbkpbot kbkpbot deleted the fix-windows-ANSI-path branch October 3, 2024 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v does not support Chinese character path name under Windows 10
2 participants