Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cgen: fix auto str for array and map for C struct #22381

Merged
merged 2 commits into from
Oct 2, 2024
Merged

cgen: fix auto str for array and map for C struct #22381

merged 2 commits into from
Oct 2, 2024

Conversation

felipensp
Copy link
Member

@felipensp felipensp commented Oct 1, 2024 •
edited by huly-for-github bot
Loading

@felipensp felipensp marked this pull request as ready for review October 1, 2024 18:40
spytheman
spytheman reviewed Oct 2, 2024
View reviewed changes
vlib/v/tests/c_structs/cstruct_arr_map_test.c.v
}
dump(t)
assert t?.a == 123
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put some assertions against the contents of g.str() and t.str() too.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(something like assert g.str().contains('a: 100') etc)

@spytheman spytheman merged commit cf2ccbc into vlang:master Oct 2, 2024
78 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spytheman spytheman spytheman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Printing struct with c alias map gives c compiler error: 'indent_struct' undeclared
2 participants
@felipensp @spytheman