flag: add optional value description to string parameters #22024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spytheman
reviewed
Aug 11, 2024
I think it would be useful for the others too. |
spytheman
changed the title
spytheman
added a commit
to martinskou/v
that referenced
this pull request
Aug 11, 2024
* master: flag: add optional value description to string parameters (vlang#22024) fmt: fix alignment of struct init fields (vlang#22025) cgen: fix selector with interface var (vlang#22006) checker: add a deprecation warning for `const ()` groups (an error after 2025-01-01) (vlang#22019) v2: fix a notice for `v cmd/v2/v2.v` tools: reduce number of os/fs calls done by `v where`; ignore tests/ folders tools: make `v where` ignore .git/ folders (they contain binary files); let `-dir .` work recursively, so that `-dir vlib` works fmt: cleanup fields alignment (vlang#22018) veb: change example description, to avoid repetitive wording (ease debugging of issue#22017) all: allow multi return as fn argument (vlang#21991) examples: change // to blank line in 2048.v too, after 793b66d all: change single blank comment to blank line (vlang#22016) scanner: guard against scanner panic, discovered by fuzzing in PR#22016 time: `d`,`c`,`dd`,`ddd`,`dddd` pattern support for parse_format() (vlang#22003) ast, parser, fmt: cleanup fmt of struct fields with empty line (vlang#22014) ast, parser, fmt: fix fmt of enum fields with empty line (vlang#22015)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using command line flags with string parameters, I found that the default val_desc values used were not as descriptive as I would like. And there was no way to override val_desc to a more descriptive value.
Using trailing struct literal arguments, I was able to add this capability without breaking any existing code.
I only did this for string parameters since that seemed to me to be the place where it would be most useful. It could easily be added to the other types if desired.