checker: fix propagation checking in c-style for loop increment #19636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since my last PR was bad, it has been rolled back. |
joshmeranda
force-pushed
the
for-propogation
branch
from
80139eb
to
8ea7785
Compare
|
@shove70 can you or someone approve the workflows to re-run when you get a chance? |
Yes, you can comment here when you need to do about it |
spytheman
reviewed
Oct 24, 2023
spytheman
reviewed
Oct 24, 2023
|
Obsoleted by #19641 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#19630
🤖 Generated by Copilot at 80139eb
The pull request adds error checking for or blocks in the for statement increment in the checker module. It also adds test cases for different kinds of or blocks in the
vlib/v/checker/testsdirectory.🤖 Generated by Copilot at 80139eb