Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

math: fix documentation for math.radians, math.degrees and math.aprox_cos #19504

Merged
merged 2 commits into from
Oct 4, 2023
Merged

math: fix documentation for math.radians, math.degrees and math.aprox_cos #19504

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
caf0e05
line: 18 approximation of sin(a) -> approximation of cos(a)
dotdot0 Oct 3, 2023
8083744
improved docstring for radian and degrees function
dotdot0 Oct 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions vlib/math/math.v
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ pub fn aprox_sin(a f64) f64 {
return a0 + a * (a1 + a * (a2 + a * (a3 + a * (a4 + a * (a5 + a * (a6 + a * a7))))))
}

// aprox_cos returns an approximation of sin(a) made using lolremez
// aprox_cos returns an approximation of cos(a) made using lolremez
spytheman marked this conversation as resolved.
Show resolved Hide resolved
pub fn aprox_cos(a f64) f64 {
a0 := 9.9995999154986614e-1
a1 := 1.2548995793001028e-3
Expand All @@ -36,7 +36,7 @@ pub fn copysign(x f64, y f64) f64 {
return f64_from_bits((f64_bits(x) & ~sign_mask) | (f64_bits(y) & sign_mask))
}

// degrees converts from radians to degrees.
// degrees converts angle from radians to degrees.
[inline]
pub fn degrees(radians f64) f64 {
return radians * (180.0 / pi)
Expand Down Expand Up @@ -153,7 +153,7 @@ pub fn signi(n f64) int {
return int(copysign(1.0, n))
}

// radians converts from degrees to radians.
// radians converts angle from degrees to radians.
[inline]
pub fn radians(degrees f64) f64 {
return degrees * (pi / 180.0)
Expand Down
Loading