Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove enum directory #75

Merged
merged 22 commits into from
Nov 16, 2022
Merged

Remove enum directory #75

merged 22 commits into from
Nov 16, 2022

Conversation

ArtemkaKun
Copy link
Contributor

The directory contains only service stuff to generate values used in the node_kind.v. Since node_kind.v was changed, and the overall implementation of c2v is stable by now, files from the enum folder can be removed.

@medvednikov
Copy link
Member

It will still be useful for new C++ nodes. I think the generator needs to be updated instead. The directory should be changed to gen/ or something like that.

@ArtemkaKun
Copy link
Contributor Author

Got it, will do

@ArtemkaKun ArtemkaKun marked this pull request as draft October 5, 2022 10:18
@ArtemkaKun
Revert "Enum directory was removed"
54bbe01 
This reverts commit b6592b5.
@ArtemkaKun
enum folder was moved to tool folder, renamed into node_kind_gen
77f394d
@ArtemkaKun
gen_str.v - reimplemented to generate map and snake_case enum values
899b2a0
@ArtemkaKun
types - sort A -> Z
7652ba4
@ArtemkaKun
node_kind.v: NodeKind enum declaration was moved on the top
4da5bb9
@ArtemkaKun
Rename: gen_str.v -> gen_node_kind_code.v
1660471
@ArtemkaKun
node_kind.v: comment about generation was added
7641030
@ArtemkaKun
gen_node_kind_code: variables name fixes
eafa193
@ArtemkaKun
gen_node_kind_code: string_to_snake_case method was refactored
9315f78
@ArtemkaKun
Merge branch 'master' into removeEnumFolder
511e5a3
@ArtemkaKun
Remove: parse.v file
98bd46e
@ArtemkaKun
Fix: straing interpolation was migrated on a new version
dd5672d
@ArtemkaKun
Refactor: string to snake case was moved to a separate module
91887a2
@ArtemkaKun
Refactor: add comments about gen_node_kind_code logic
2800e96
@ArtemkaKun
Fix: NodeKind members generation
64a2118
@ArtemkaKun
Merge branch 'master' into removeEnumFolder
4fd4b8e
@ArtemkaKun
Refactor: types file name become a variable
0d7cca4
@ArtemkaKun
Fix: NodeKind enum member bad was added to generation
22354af
@ArtemkaKun ArtemkaKun marked this pull request as ready for review November 2, 2022 21:36
@ArtemkaKun
Copy link
Contributor Author

@medvednikov Hi, what do you think now?

@ArtemkaKun
Copy link
Contributor Author

@medvednikov

What was done in this PR:

  • types file was sorted A -> Z
  • parse.v file was removed
  • gen_str.v file was refactored to generate NodeKind code and related dictionary with improvements (like auto snake_case for entries in types file)

@medvednikov medvednikov merged commit fea624e into vlang:master Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medvednikov medvednikov Awaiting requested review from medvednikov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ArtemkaKun @medvednikov