Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix var/const conflict, update format of test output, update json ignore #181

Merged
merged 5 commits into from
Aug 26, 2024

Conversation

JalonSolov
Copy link
Contributor

@JalonSolov JalonSolov commented Aug 25, 2024

Had to fix tests/5.struct.out due to recent changes in v fmt.

Fixed vlang/v#22116

@JalonSolov
Copy link
Contributor Author

No idea why this is failing on macos... clang version, perhaps?

@spytheman
Copy link
Member

I am checking on my m1 right now.

@spytheman
Copy link
Member

It is reproducible locally.

@spytheman
Copy link
Member

The getline functions is declared on the C side 🤔 :

0[16:20:54]@m1: (master) /opt/v $ rg getline /Applications/Xcode.app/Contents/Developer//Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/stdio.h
358:ssize_t getline(char ** __restrict __linep, size_t * __restrict __linecapp, FILE * __restrict __stream) __OSX_AVAILABLE_STARTING(__MAC_10_7, __IPHONE_4_3);

@spytheman
Copy link
Member

spytheman commented Aug 26, 2024

It is present in the clang's JSON output too:

      "isUsed": true,
      "name": "getline",
      "mangledName": "_getline",
      "type": {
        "qualType": "ssize_t (char **restrict, size_t *restrict, FILE *restrict)"
      },

@spytheman
Copy link
Member

Afaik it is a regression from eafdd3c . For now, I've changed the .out file for macos to match the new output, so that the CI can pass :-| .

@spytheman spytheman merged commit 773f557 into vlang:master Aug 26, 2024
3 checks passed
@JalonSolov JalonSolov deleted the fix_var_conflict branch August 26, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to compile C2V
2 participants