Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve robustness of print_debug by handling missing system profiler keys #13

Merged

Conversation

chenrui333
Copy link
Contributor

@chenrui333 chenrui333 commented Dec 11, 2024

seeing some crash in CI, add some fallback for system profile checks

==> /opt/homebrew/Cellar/macmon/0.4.0/bin/macmon debug
thread 'main' panicked at src/debug.rs:26:74:
called `Option::unwrap()` on a `None` value
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

and now it would be

==> /opt/homebrew/Cellar/macmon/0.4.0/bin/macmon debug
Error: "Failed to get channels"
Chip: Apple M1 (Virtual) | Model: VirtualMac2,1 | OS: macOS 15.1.1 (24B91) | Unknown processors

--- AppleARMIODevice -----------------------------------------------------------

--- IOReport -------------------------------------------------------------------
/opt/homebrew/Library/Homebrew/ignorable.rb:27:in `block in raise'
Minitest::Assertion: Expected: 0
  Actual: 1

relates to Homebrew/homebrew-core#200767

… profiler keys

Signed-off-by: Rui Chen <rui@chenrui.dev>
@vladkens vladkens merged commit aec0311 into vladkens:main Dec 14, 2024
@vladkens
Copy link
Owner

vladkens commented Dec 14, 2024

Hi, @chenrui333. Merged. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants