-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move constants out of global namespace #38
Conversation
require_relative 'itext' | ||
|
||
class FillablePDF | ||
class Field |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be a module instead, since we're not creating any instances
Given that this is a break change, did you actually encounter an issue where you had a conflict with another gem or your own code? |
Yes, and I think this will keep people from using this gem. |
Thanks for the pull request. I will try to review and merge it right away and release a new version of the gem. |
The changes look great. The only thing that is missing is updates to |
I was trying to resolve conflicts between this branch and the previous branch you had pushed, which I recently merged, and it looks like it broke something. :( |
af4ab91
to
f4b8c7e
Compare
Defining constants in the global namespace is dangerous as it might conflict with other libraries/apps. Note: This is a breaking change.
f4b8c7e
to
4d7daa2
Compare
@vkononov I've updated the references to |
Looks great. Thank you, @MatheusRich, for making these changes. Will merge right away and release a new version of the gem sometime today. |
Defining constants in the global namespace is dangerous as it might conflict with other libraries/apps.
Note: This is a breaking change.