This repository has been archived by the owner on Sep 1, 2020. It is now read-only.
Make menu closable with escape key #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution. This indeed is a nice contribution. Please see my comments |
vkbansal
suggested changes
Feb 14, 2017
| @@ -64,6 +64,7 @@ export default class ContextMenu extends Component { | |||
| document.addEventListener('ontouchstart', this.handleOutsideClick); | |||
| document.addEventListener('scroll', this.handleHide); | |||
| document.addEventListener('contextmenu', this.handleHide); | |||
| document.addEventListener('keyup', this.handleEscape); | |||
There was a problem hiding this comment.
also remove the event listener in unregisterHandlers
vkbansal
approved these changes
Feb 14, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready
Description
Allows the context menu to be closed by pressing the escape key. I think this is expected behavior with a context menu and would be a good addition to the library.