Skip to content
This repository has been archived by the owner on Sep 1, 2020. It is now read-only.

Fixes #105: properly call mousedown, mouseup, touchstart, touchend, m… #107

Merged
merged 1 commit into from
May 11, 2017
Merged

Fixes #105: properly call mousedown, mouseup, touchstart, touchend, m… #107

merged 1 commit into from
May 11, 2017

Conversation

julienw
Copy link
Contributor

@julienw julienw commented May 10, 2017

…ouseout and contextmenu event handlers if they're specified.

@julienw julienw force-pushed the 105-fix-attributes-mousedown-etc branch 2 times, most recently from f26caf9 to f28686f Compare May 10, 2017 12:41
@julienw
Copy link
Contributor Author

julienw commented May 10, 2017

Not sure how I could write tests for this.

@julienw julienw mentioned this pull request May 10, 2017
Closed
@vkbansal
Copy link
Owner

Please rebase with master now

@julienw
Fixes vkbansal#105: properly call mousedown, mouseup, touchstart, tou…
3db73bd 
…chend, mouseout and contextmenu event handlers if they're specified.
@julienw julienw force-pushed the 105-fix-attributes-mousedown-etc branch from f28686f to 3db73bd Compare May 11, 2017 08:41
@julienw
Copy link
Contributor Author

julienw commented May 11, 2017

Rebased.

Now I can see a non-failing error in Travis output but I think it's unrelated:

console.error node_modules/fbjs/lib/warning.js:36

    Warning: Failed prop type: The prop `children` is marked as required in `ContextMenu`, but its value is `undefined`.

        in ContextMenu

@vkbansal vkbansal merged commit a2f294a into vkbansal:master May 11, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vkbansal vkbansal vkbansal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julienw @vkbansal