Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(core): use sync_wrapper to wrap boxed body #116

Merged
merged 4 commits into from
Dec 18, 2023
Merged

chore(core): use sync_wrapper to wrap boxed body #116

merged 4 commits into from
Dec 18, 2023

Conversation

fundon
Copy link
Member

@fundon fundon commented Dec 16, 2023

@fundon
Copy link
Member Author

fundon commented Dec 17, 2023

See https://internals.rust-lang.org/t/what-shall-sync-mean-across-an-await/12020/22

Gets a reference to the underlying data is disallow.

@fundon fundon closed this Dec 17, 2023
@fundon fundon deleted the use_sync_wrapper_on_boxed_body branch December 17, 2023 22:00
@fundon
Copy link
Member Author

fundon commented Dec 17, 2023

https://docs.rs/crate/async-compression/0.3.1/source/src/unshared.rs

@fundon fundon restored the use_sync_wrapper_on_boxed_body branch December 18, 2023 00:01
@fundon fundon reopened this Dec 18, 2023
@fundon fundon force-pushed the use_sync_wrapper_on_boxed_body branch from d47e67a to 80a8c56 Compare December 18, 2023 00:20
@fundon fundon force-pushed the use_sync_wrapper_on_boxed_body branch from 9c5885c to 7465bff Compare December 18, 2023 00:24
@fundon fundon merged commit 6841523 into main Dec 18, 2023
@fundon fundon deleted the use_sync_wrapper_on_boxed_body branch December 18, 2023 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@fundon