-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Page loading improvements #98
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and simplify the types a bit too, to help with maintenability
(i.e. with `Adw.ToolbarView`'s)
vixalien
force-pushed
the
page-improvements
branch
from
February 5, 2024 12:31
00ec5cb
to
adc34ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The primary target of this PR was to allow pages to be refreshed, but it turned into a yak shaving session. I improved the working of the
Page
andNavigation
components, allowing easy refreshing. Here's a bit of elements on the TODO list.Page
Page
Replace the current page when instead of pushing a new one:
I aim to allow most pages to be refreshed, but some pages don't need to be refreshed (I may be wrong).
Another thing to consider if it is a good idea to show the content page while reloading. Currently, the page is turned to the "loading" state while a reload happens. I would like to hear your input.
Pages with a reload function: