Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page loading improvements #98

Merged
merged 15 commits into from
Feb 5, 2024
Merged

Page loading improvements #98

merged 15 commits into from
Feb 5, 2024

Conversation

vixalien
Copy link
Owner

@vixalien vixalien commented Feb 4, 2024

The primary target of this PR was to allow pages to be refreshed, but it turned into a yak shaving session. I improved the working of the Page and Navigation components, allowing easy refreshing. Here's a bit of elements on the TODO list.

Replace the current page when instead of pushing a new one:

  • Search view (when a filter is applied)
  • Library (when sort is changed)
  • Library Playlists (ditto...)
  • Library Albums
  • Library Artists
  • Library Subscriptions
  • Library Songs
  • Charts (when the country is changed)

I aim to allow most pages to be refreshed, but some pages don't need to be refreshed (I may be wrong).

Another thing to consider if it is a good idea to show the content page while reloading. Currently, the page is turned to the "loading" state while a reload happens. I would like to hear your input.

Pages with a reload function:

  • Home
  • Playlist
  • Album
  • Artist
  • Search Results
  • Library
  • Library Playlists
  • Library Albums
  • Library Artists
  • Library Subscriptions
  • Library Songs
  • History
  • Artist Albums
  • Channel
  • Channel Playlists
  • Explore
  • Charts
  • Moods and genres
  • Mood
  • New Releases
  • Allow getting a new login code

@vixalien vixalien mentioned this pull request Feb 4, 2024
12 tasks
@vixalien vixalien merged commit e2339ff into main Feb 5, 2024
4 checks passed
@vixalien vixalien deleted the page-improvements branch February 5, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant