feat: Support printing mixed page sizes #912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Tested: #751 (comment) |
…s files There have been four same stylesheet sets (vivliostyle-viewport.css and vivliostyle-viewport-screen.css) in the following files: - packages/core/resources/vivliostyle-viewport(-screen).css - packages/viewer/resources/vivliostyle-viewport(-screen).css - bundled copy in packages/core/src/vivliostyle/assets.ts - bundled copy in packages/react/src/renderer.tsx These are redundant and hard to maintain keeping consistent style rules in these all files. To resolve this problem, this commit removes these stylesheets except in packages/core/src/vivliostyle/assets.ts, and modifies the AdaptiveViewer constructor so that the style elements are dynamically generated using the stylesheets in packages/core/src/vivliostyle/assets.ts. In addition, it moves the code that generates the style element for text-polyfill-css from text-polyfill.ts to the AdaptiveViewer constructor.
- resolves #751 This change enables mixed page sizes in output PDF together with the following change in vivliostyle-cli: - vivliostyle/vivliostyle-cli#278 When multiple page sizes are specified, as in the example in Issue 751, the largest page size both vertically and horizontally are used in PDF output from Vivliostyle.js. Then the PDF is post-processed in the Vivliostyle CLI to set the multiple page sizes as specified.
MurakamiShinyu
force-pushed
the
feat/issue751
branch
from
f8bd95c
to
76d1ed2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change enables mixed page sizes in output PDF together with the following change in vivliostyle-cli:
When multiple page sizes are specified, as in the example in Issue 751, the largest page size both vertically and horizontally are used in PDF output from Vivliostyle.js.
Then the PDF is post-processed in the Vivliostyle CLI to set the multiple page sizes as specified.