Support the @supports CSS at-rule
#762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code was added in the commit f1da32b on Nov 5, 2015. https://github.com/vivliostyle/vivliostyle.js/blob/f1da32b54843bb3d9ef2d50ab282f73b36df15b7/src/adapt/expr.js#L1333-L1338 It seems that the `this.value.dependOuter(other, context, dependencyCache)` has error (`this.value` is never set) and is never evaluated, so this override method should not have been added.
Spec: CSS Conditional Rules Module Level 3 https://www.w3.org/TR/css-conditional-3/ Tests: https://github.com/web-platform-tests/wpt/tree/master/css/css-conditional Now it passes all non-javascript tests in the https://github.com/web-platform-tests/wpt/tree/master/css/css-conditional except "at-supports-040.html" that is for the Level 4 `selector(...)` not supported yet and "css-supports-042.xht" that is an edge case that Chromium also fails. resolves #730
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/vivliostyle/vivliostyle/5jcbKvakjaYRoQn2KW6NWtbrG2bU |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spec: CSS Conditional Rules Module Level 3 https://www.w3.org/TR/css-conditional-3/
Tests: https://github.com/web-platform-tests/wpt/tree/master/css/css-conditional
Now it passes all non-javascript tests in https://github.com/web-platform-tests/wpt/tree/master/css/css-conditional
except "at-supports-040.html" that is for the Level 4
selector(...)not supported yetand "css-supports-042.xht" that is an edge case that Chromium also fails.
resolves #730