feat(core): Support the :nth() page selector #700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spec: https://drafts.csswg.org/css-gcpm-3/#document-page-selectors Notes: - The `:nth(An+B)` syntax is supported but the `:nth(An+B of <custom-ident>)` is not because the named pages are not yet supported. - In multi-document publications, the `:nth(1)` matches the first page of each document, but the `:first` matches only the first page of the first document. (see: #667 (comment) ) Test files: - packages/core/test/files/nth-page/nth-page.html - packages/core/test/files/nth-page/nth-page-counter-reset.html Fixes #667
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/vivliostyle/vivliostyle/3TsZZDrL9iLytAYCL4tjmg7hsZuv |
|
This PR also resolves #522 "counter-reset: page;" doesn't work properly with web publications. |
This was referenced Feb 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spec: https://drafts.csswg.org/css-gcpm-3/#document-page-selectors
Notes:
:nth(An+B)syntax is supported but the:nth(An+B of <custom-ident>)is notbecause the named pages are not yet supported.
:nth(1)matches the first page of each document,but the
:firstmatches only the first page of the first document.(see: First-page pseudo-class :first should work on each document in a multi-document publication? (→support :nth()) #667 (comment) )
Test files:
https://raw.githack.com/vivliostyle/vivliostyle.js/master/packages/core/test/files/#Nth_page_selector
Fixes #667