Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change directory structure #552

Merged
merged 2 commits into from
Oct 7, 2019
Merged

Change directory structure #552

merged 2 commits into from
Oct 7, 2019

Conversation

kubosho
Copy link
Contributor

@kubosho kubosho commented Oct 5, 2019 •
edited
Loading

Motivation

adapt directory name is origin from the https://github.com/sorotokin/adaptive-layout, but it is a confusing name for those who don't know anything.

Solution

I collected all the adapt files under vivliostyle.

@kubosho
Copy link
Contributor Author

kubosho commented Oct 5, 2019

ERROR [SaucelabsLauncher]: WebDriverError: Misconfigured -- Sauce Labs Authentication Error.
You used username 'undefined' and access key 'undefined' to authenticate, which are not valid Sauce Labs credentials.

🤔

MurakamiShinyu added a commit that referenced this pull request Oct 7, 2019
@MurakamiShinyu
Work around Travis CI failed on pull request from external contributors
574a156 
Problem: #552 (comment)
> ERROR [SaucelabsLauncher]: WebDriverError: Misconfigured -- Sauce Labs Authentication Error.
> You used username 'undefined' and access key 'undefined' to authenticate, which are not valid Sauce Labs credentials.

The reason of this error: Pull Requests and Security Restrictions
https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
> If your build relies on encrypted variables to run, for instance to run …Sauce Labs, your build needs to take this into account.
> You won’t be able to run these tests for pull requests from external contributors.
> To work around this, restrict these tests only to situations where the environment variables are available, …
@MurakamiShinyu
Copy link
Member

I made a workaround for Travis CI error: 574a156

@MurakamiShinyu MurakamiShinyu merged commit f2c6575 into vivliostyle:master Oct 7, 2019
@kubosho kubosho deleted the change-directory-structure branch October 7, 2019 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kubosho @MurakamiShinyu