WIP: do not download resources separately #503
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't have the faintest idea of why the tests are failing. I cannot even find documentation about closure on the net anymore. I'm stumbling around rather blindly. So take this PR more as an example of what I'd like to achieve. @MurakamiShinyu |
MurakamiShinyu
added a commit
that referenced
this pull request
Aug 13, 2019
This is TS-converted work of WIP: do not download resources separately #503
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @MurakamiShinyu . Something like this is what I am thinking about. It seems like we don't really need to serve the resources directory separately. Or is there something I am missing? This is related to #502
PS: Do not actually merge this without having looked through it. I have a hard time understanding the syntax so if it's working it's just by pure luck.