Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change hard line breaks to optional #50

Closed
akabekobeko opened this issue Jan 10, 2021 · 5 comments
Closed

Change hard line breaks to optional #50

akabekobeko opened this issue Jan 10, 2021 · 5 comments
Assignees
Labels
spec Spec related thing
Milestone

Comments

@akabekobeko
Copy link
Member

akabekobeko commented Jan 10, 2021

Goals

Change hard line breaks to optional.

VFM will be based on CommonMark/GFM and will add its own syntax. When overwriting the function of CommonMark/GFM, it is treated as an option. Do not overwrite the function until the option is specified.

Prior Art

CommonMark/GFM

Discussion

Discussed and approved in Developers meeting January 2021.

@akabekobeko akabekobeko added the spec Spec related thing label Jan 10, 2021
@akabekobeko akabekobeko changed the title spec: Overrides CommonMark / GFM is optional spec: Overrides CommonMark/GFM is optional Jan 10, 2021
@akabekobeko akabekobeko self-assigned this Jan 12, 2021
@akabekobeko
Copy link
Member Author

akabekobeko commented Jan 15, 2021

#38 の原因と予想される remark-breaks は CommonMark/GFM の挙動を上書きするため、オプション扱いとする予定。

@akabekobeko
Copy link
Member Author

akabekobeko commented Jan 15, 2021

オプション案。

  • API: autoLineBreaks: boolean 既定値は無効で false
  • CLI: = --auto-line-breaks 使用頻度は高くなさそうなためショート ハンドは提供しない

現行の実装では rehive-parse.ts にて MDAST 系を静的に定義しているが、オプションにより構成を変更可能とするように設計変更する必要がある。

@akabekobeko akabekobeko changed the title spec: Overrides CommonMark/GFM is optional spec: Change automatic line breaks to optional Jan 15, 2021
@akabekobeko
Copy link
Member Author

#59 対応により buildProcessorTestingCode へ VFM オプションを渡せるようになったので改行の <br> 変換を想定したコードでは本 issue 対応時に必ず指定すること。

@akabekobeko akabekobeko changed the title spec: Change automatic line breaks to optional Change automatic line breaks to optional Jan 17, 2021
@MurakamiShinyu
Copy link
Member

オプション案の修正案 (See: #64 (comment)):

  • API: hardLineBreaks
  • CLI: --hard-line-breaks

akabekobeko added a commit that referenced this issue Jan 20, 2021
feat: Change automatic line breaks to optional
@akabekobeko
Copy link
Member Author

村上さん案を #64 に採用しました。v1.0.0-alpha.16 にて反映予定です

@akabekobeko akabekobeko changed the title Change automatic line breaks to optional Change hard line breaks to optional Jan 21, 2021
@akabekobeko akabekobeko added this to the v1.0.0 milestone Apr 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec Spec related thing
Projects
None yet
Development

No branches or pull requests

2 participants