VIVI-5527 parse service data #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewjpritchard
commented
Feb 7, 2021
andrewjpritchard
commented
- Parse service data given from modified version of BLEServer.exe
- The modified version of BLEServer.exe can be found at https://github.com/viviedu/web-bluetooth-polyfill-1
added 2 commits
February 5, 2021 11:23
VIVI-5527 - BLEServer is an executable from the `web-bluetooth-polyfill` repository - It has been modified to return the raw AD structures - This patch retrieves the relevant service data from BLEServer, formats it and returns it - Additionally, it falls back to `@abandonware/noble` which is the up-to-date version of `noble`
bindings.js
Outdated
Comment on lines
201
to
202
| "uuid": this._toHex(adStructure.data[1]) + this._toHex(adStructure.data[0]), | ||
| "data": Buffer.from(adStructure.data.slice(2)) |
There was a problem hiding this comment.
quotes are redundant here, right?
bindings.js
Outdated
| @@ -190,6 +192,17 @@ class WinrtBindings extends events.EventEmitter { | |||
| } | |||
| } | |||
|
|
|||
| // This will only retrive service data with 16 bit UUIDs. If you need | |||
tristanpenman
approved these changes
Feb 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.