Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt and correct usage of link #3579

Open
wants to merge 7 commits into
base: next
Choose a base branch
from
Open

Adapt and correct usage of link #3579

wants to merge 7 commits into from

Conversation

juliawegmayr
Copy link
Contributor

@juliawegmayr juliawegmayr commented Mar 5, 2025 •
edited
Loading

Description

  • Adapt Link Styling according to design
  • Remove MuiLinks from components, that should not use the MuiLink (all Links that are not simple links in text or stand-alone Text-links) and replace them with components that fit better.

Acceptance criteria

Screenshots/screencasts

Before After
Screenshot 2025-03-05 at 15 08 37 Screenshot 2025-03-05 at 15 08 48

Open TODOs/questions

  • Add changeset

Further information

@juliawegmayr juliawegmayr changed the base branch from main to next March 5, 2025 09:23
@juliawegmayr juliawegmayr force-pushed the adapt-and-correct-usage-of-link branch from ce481ae to befada3 Compare March 5, 2025 12:32
@juliawegmayr juliawegmayr marked this pull request as ready for review March 5, 2025 14:21
@auto-assign auto-assign bot requested a review from johnnyomair March 5, 2025 14:21
@juliawegmayr juliawegmayr requested review from jamesricky and johnnyomair and removed request for johnnyomair March 5, 2025 14:21
juliawegmayr and others added 3 commits March 6, 2025 09:04
@juliawegmayr @jamesricky
remove styling used for debugging
280e1a6 
Co-authored-by: Ricky James Smith <jamesricky@me.com>
@juliawegmayr @jamesricky
remove inline styling, which is included in the styled component
fa23a9e 
Co-authored-by: Ricky James Smith <jamesricky@me.com>
@juliawegmayr
fix linting error
002b10a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesricky jamesricky jamesricky requested changes

@johnnyomair johnnyomair Awaiting requested review from johnnyomair

Requested changes must be addressed to merge this pull request.

Assignees

@juliawegmayr juliawegmayr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juliawegmayr @jamesricky