Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COM-957: Add basic warning entity #2503

Merged
merged 6 commits into from
Oct 14, 2024
Merged

Conversation

raphaelblum
Copy link
Contributor

@raphaelblum raphaelblum commented Sep 4, 2024


Description:
In the Warning Module there should be a warning entity where warnings are saved.
Entries into this table should later be added with a validator or via a block, maybe even manually.
This is the start of the central warning system in order to have a basic table and to be able to start with the validator afterwards.

Questions:

  • Move warning.entity and related code to cms-api. For now I think it makes sense to keep it in the demo, since I easily can rerun api generator again. Or should I look into making the api generator available also in the cms-api package? I'm not sure if this can or should work.
  • Changeset: I think it makes sense adding a changeset for the Feature branch instead of a lot small changesets while developing in the feature branch, or what do you say?

My next Step:
Detecting warnings for a simple example, maybe for a Job or for invalid Blockdata. Finding the "error" and creating a warning.

Later on we probably need something like a Message or Warning Info. I'd look into this later. I haven't thought about how this could work yet (intl in api?)

PR Checklist

  • Verify if the change requires a changeset. See CONTRIBUTING.md
  • Link to the respective task if one exists:
  • Provide screenshots/screencasts if the change contains visual changes
Screen.Recording.2024-10-04.at.10.58.36.mov

@raphaelblum raphaelblum self-assigned this Sep 4, 2024
@raphaelblum raphaelblum changed the title add basic warning entity Draft: add basic warning entity Sep 5, 2024
@raphaelblum raphaelblum changed the base branch from main to feature/warning-module September 5, 2024 10:17
@johnnyomair
Copy link
Collaborator

@raphaelblum do you want us to review this, or is it WIP?

@raphaelblum
Copy link
Contributor Author

raphaelblum commented Oct 3, 2024

@raphaelblum do you want us to review this, or is it WIP?

still Draft, unfortunately, but it seems like I'm having time to continue working on it now

@raphaelblum raphaelblum marked this pull request as ready for review October 4, 2024 09:40
@raphaelblum raphaelblum changed the title Draft: add basic warning entity COM-957 add basic warning entity Oct 4, 2024
@johnnyomair
Copy link
Collaborator

Move warning.entity and related code to cms-api. For now I think it makes sense to keep it in the demo, since I easily can rerun api generator again. Or should I look into making the api generator available also in the cms-api package? I'm not sure if this can or should work.

Yes, keep it in the Demo for now.

Changeset: I think it makes sense adding a changeset for the Feature branch instead of a lot small changesets while developing in the feature branch, or what do you say?

Yes, one changeset for the feature (and preferably docs as well).

@johnnyomair johnnyomair changed the title COM-957 add basic warning entity COM-957: Add basic warning entity Oct 10, 2024
@johnnyomair johnnyomair merged commit 859eed8 into feature/warning-module Oct 14, 2024
3 checks passed
@johnnyomair johnnyomair deleted the warning-entity branch October 14, 2024 06:50
raphaelblum added a commit that referenced this pull request Oct 23, 2024
In the Warning Module there should be a warning entity where warnings
are saved.
Entries into this table should later be added with a validator or via a
block, maybe even manually.
This is the start of the central warning system in order to have a basic
table and to be able to start with the validator afterwards.
raphaelblum added a commit that referenced this pull request Oct 23, 2024
In the Warning Module there should be a warning entity where warnings
are saved.
Entries into this table should later be added with a validator or via a
block, maybe even manually.
This is the start of the central warning system in order to have a basic
table and to be able to start with the validator afterwards.
raphaelblum added a commit that referenced this pull request Feb 20, 2025
In the Warning Module there should be a warning entity where warnings
are saved.
Entries into this table should later be added with a validator or via a
block, maybe even manually.
This is the start of the central warning system in order to have a basic
table and to be able to start with the validator afterwards.
raphaelblum added a commit that referenced this pull request Feb 20, 2025
In the Warning Module there should be a warning entity where warnings
are saved.
Entries into this table should later be added with a validator or via a
block, maybe even manually.
This is the start of the central warning system in order to have a basic
table and to be able to start with the validator afterwards.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants