Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Admin Generator (Future): Add support for file upload fields in forms #2363

Merged
merged 4 commits into from
Aug 21, 2024
Merged

Admin Generator (Future): Add support for file upload fields in forms #2363

merged 4 commits into from
Aug 21, 2024

Conversation

jamesricky
Copy link
Contributor

@jamesricky jamesricky commented Jul 31, 2024 •
edited
Loading

PR Checklist

@auto-assign auto-assign bot requested a review from johnnyomair July 31, 2024 07:55
@jamesricky jamesricky requested a review from nsams July 31, 2024 08:02
Base automatically changed from public-upload-file-endpoints to main August 6, 2024 14:42
@jamesricky jamesricky marked this pull request as draft August 6, 2024 14:58
@jamesricky jamesricky changed the base branch from main to public-upload-file-endpoints August 6, 2024 14:59
@jamesricky jamesricky force-pushed the upload-field-in-form-generator branch from de44f46 to e4289e3 Compare August 7, 2024 06:30
Base automatically changed from public-upload-file-endpoints to main August 7, 2024 06:31
@jamesricky jamesricky force-pushed the upload-field-in-form-generator branch from e4289e3 to 12011e5 Compare August 7, 2024 06:37
@jamesricky jamesricky marked this pull request as ready for review August 7, 2024 06:41
@auto-assign auto-assign bot requested a review from johnnyomair August 7, 2024 06:41
@jamesricky jamesricky requested a review from nsams August 7, 2024 06:41
@johnnyomair johnnyomair changed the title Admin Generator (Future): Add support for file upload in admin generator Admin Generator (Future): Add support for file upload fields in forms Aug 13, 2024
johnnyomair
johnnyomair previously approved these changes Aug 13, 2024
View reviewed changes
Copy link
Collaborator

@johnnyomair johnnyomair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please wait for @nsams' review though.

@jamesricky jamesricky force-pushed the upload-field-in-form-generator branch from ecf820d to 2576740 Compare August 14, 2024 06:32
@Ben-Ho Ben-Ho mentioned this pull request Aug 20, 2024
Draft
@jamesricky jamesricky merged commit 05e154a into main Aug 21, 2024
11 checks passed
@jamesricky jamesricky deleted the upload-field-in-form-generator branch August 21, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nsams nsams nsams approved these changes

@johnnyomair johnnyomair johnnyomair approved these changes

Assignees

@jamesricky jamesricky

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jamesricky @nsams @johnnyomair