-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Admin Generator (Future): Allow Grid independent of Stack: Inject add and edit button from outside #2171
Conversation
bfb13fe
to
2a6080a
Compare
This grid is also used for "low-price" page where add and edit buttons aren't really required.
c28e011
to
ee26209
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about using the name actions instead of buttons?
actionsProps: true
toolbarActions
or primaryAction
rowAction
Would be more versatile
this could probably lead to confusion with #1913. But one of the two buttons is actually an action-button... what do you think about Or your example |
This would imply that it must always be a button and a navigation, while it doesn't have to be either IMO.
Would be okay for me. @nsams what do you think? |
then I'll go with toolbarActionProp and rowActionProp because it contains the location. and primary is defined by styling so this isn't correct either. |
{ ..., add: false, ...}
andadd: true
configuration at the same time.