Make it possible to remove the "Hide in menu" field from `createEditP…

…ageNode` (#2052) In some of our projects, the menu isn't generated directly from the PageTree (but can be built separately). In that case it doesn't make sense to have a "Hide in menu" checkbox and it's confusing to the users. Thus, I added this option. --------- Co-authored-by: Johannes Obermair <48853629+johnnyomair@users.noreply.github.com>
vivid-planet · May 14, 2024 · f89af8b · f89af8b
1 parent 584d14d
commit f89af8b
Show file tree

Hide file tree

Showing 3 changed files with 29 additions and 19 deletions.
diff --git a/.changeset/breezy-suns-nail.md b/.changeset/breezy-suns-nail.md
@@ -0,0 +1,5 @@
+---
+"@comet/cms-admin": minor
+---
+
+Add `disableHideInMenu` option to `createEditPageNode` to hide the "Hide in menu" checkbox 
diff --git a/demo/admin/src/common/EditPageNode.tsx b/demo/admin/src/common/EditPageNode.tsx
@@ -32,6 +32,7 @@ export const additionalPageTreeNodeFieldsFragment = {
 };
 
 export const EditPageNode = createEditPageNode({
+    disableHideInMenu: false,
     valuesToInput: ({ values }: { values: { userGroup: string } }) => {
         return {
             userGroup: values.userGroup,

diff --git a/packages/admin/cms-admin/src/pages/createEditPageNode.tsx b/packages/admin/cms-admin/src/pages/createEditPageNode.tsx
@@ -39,6 +39,7 @@ interface CreateEditPageNodeProps {
     additionalFormFields?: React.ReactNode;
     nodeFragment?: { name: string; fragment: DocumentNode };
     valuesToInput?: (values: EditPageNodeFinalFormValues) => EditPageNodeFinalFormValues;
+    disableHideInMenu?: boolean;
 }
 
 export interface EditPageNodeProps {
@@ -52,6 +53,7 @@ export function createEditPageNode({
     additionalFormFields,
     nodeFragment,
     valuesToInput,
+    disableHideInMenu = false,
 }: CreateEditPageNodeProps): (props: EditPageNodeProps) => JSX.Element {
     const editPageNodeQuery = gql`
         query EditPageNode($id: ID!) {
@@ -446,25 +448,27 @@ export function createEditPageNode({
                                         </FinalFormSelect>
                                     )}
                                 </Field>
-                                <Field
-                                    label={intl.formatMessage({
-                                        id: "comet.pages.pages.page.menuVisibility",
-                                        defaultMessage: "Menu Visibility",
-                                    })}
-                                    name="hideInMenu"
-                                    type="checkbox"
-                                    variant="horizontal"
-                                >
-                                    {(props) => (
-                                        <FormControlLabel
-                                            label={intl.formatMessage({
-                                                id: "comet.pages.pages.page.hideInMenu",
-                                                defaultMessage: "Hide in Menu",
-                                            })}
-                                            control={<FinalFormCheckbox {...props} />}
-                                        />
-                                    )}
-                                </Field>
+                                {!disableHideInMenu && (
+                                    <Field
+                                        label={intl.formatMessage({
+                                            id: "comet.pages.pages.page.menuVisibility",
+                                            defaultMessage: "Menu Visibility",
+                                        })}
+                                        name="hideInMenu"
+                                        type="checkbox"
+                                        variant="horizontal"
+                                    >
+                                        {(props) => (
+                                            <FormControlLabel
+                                                label={intl.formatMessage({
+                                                    id: "comet.pages.pages.page.hideInMenu",
+                                                    defaultMessage: "Hide in Menu",
+                                                })}
+                                                control={<FinalFormCheckbox {...props} />}
+                                            />
+                                        )}
+                                    </Field>
+                                )}
 
                                 {additionalFormFields}
                             </>