Fix key as adminRoute is not necessarily unique (#2441)

Fixes a bug where a block's hover-overlay element in the admin preview might persist after the underlying element is moved or resized.
vivid-planet · Aug 27, 2024 · f2e10ec · f2e10ec
1 parent 3f1b961
commit f2e10ec
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/.changeset/twenty-mirrors-taste.md b/.changeset/twenty-mirrors-taste.md
@@ -0,0 +1,5 @@
+---
+"@comet/cms-site": patch
+---
+
+Fix a bug where a block's hover-overlay element in the admin preview might persist after the underlying element is moved or resized
diff --git a/packages/site/cms-site/src/iframebridge/PreviewOverlay.tsx b/packages/site/cms-site/src/iframebridge/PreviewOverlay.tsx
@@ -22,14 +22,14 @@ export const PreviewOverlay = () => {
 
     return (
         <OverlayRoot style={{ height: bottomMostElementPosition }}>
-            {iFrameBridge.previewElementsData.map((element) => {
+            {iFrameBridge.previewElementsData.map((element, index) => {
                 const isSelected = element.adminRoute === iFrameBridge.selectedAdminRoute;
 
                 if (isSelected && lastSelectedElementPath !== element.adminRoute) {
                     lastSelectedElementPath = element.adminRoute;
                 }
 
-                return <PreviewOverlayElement key={element.adminRoute} element={element} />;
+                return <PreviewOverlayElement key={index} element={element} />;
             })}
         </OverlayRoot>
     );