Admin Generator (Future): Fix the default width of "actions" columns (#…

…2489) When there are exactly two icon buttons inside the actions cell, which is the default for generated grids, it should be 84px wide. If more actions are added, the width needs to be adjusted manually anyway, see the existing (future generator) `ProductsGrid`.
vivid-planet · Aug 30, 2024 · e39dd31 · e39dd31
1 parent c130adc
commit e39dd31
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 0 deletions.
diff --git a/demo/admin/src/products/ManufacturersGrid.tsx b/demo/admin/src/products/ManufacturersGrid.tsx
@@ -127,6 +127,8 @@ export function ManufacturersGrid() {
             headerName: "",
             sortable: false,
             filterable: false,
+            pinned: "right",
+            width: 84,
             renderCell: (params) => {
                 return (
                     <>

diff --git a/demo/admin/src/products/future/generated/ManufacturersGrid.tsx b/demo/admin/src/products/future/generated/ManufacturersGrid.tsx
@@ -195,6 +195,7 @@ export function ManufacturersGrid(): React.ReactElement {
             type: "actions",
             align: "right",
             pinned: "right",
+            width: 84,
             renderCell: (params) => {
                 return (
                     <>

diff --git a/demo/admin/src/products/future/generated/ProductVariantsGrid.tsx b/demo/admin/src/products/future/generated/ProductVariantsGrid.tsx
@@ -121,6 +121,7 @@ export function ProductVariantsGrid({ product }: Props): React.ReactElement {
             type: "actions",
             align: "right",
             pinned: "right",
+            width: 84,
             renderCell: (params) => {
                 return (
                     <>

diff --git a/packages/admin/cms-admin/src/generator/future/generateGrid.ts b/packages/admin/cms-admin/src/generator/future/generateGrid.ts
@@ -235,6 +235,7 @@ export function generateGrid(
         type: actionsColumnType,
         headerName: actionsColumnHeaderName,
         pinned: actionsColumnPinned = "right",
+        width: actionsColumnWidth = 84,
         ...restActionsColumnConfig
     } = actionsColumnConfig ?? {};
 
@@ -547,6 +548,7 @@ export function generateGrid(
                               type: '"actions"',
                               align: '"right"',
                               pinned: `"${actionsColumnPinned}"`,
+                              width: actionsColumnWidth,
                               ...restActionsColumnConfig,
                               renderCell: `(params) => {
                             return (