Skip to content

Commit

Permalink
Add queryUpdatedAt helper that can be used in checkConflict without h…
Browse files Browse the repository at this point in the history
…aving the write an addtional query
  • Loading branch information
nsams committed May 17, 2023
1 parent 2824f8a commit adb5bc3
Show file tree
Hide file tree
Showing 5 changed files with 30 additions and 19 deletions.
5 changes: 5 additions & 0 deletions .changeset/cuddly-kings-build.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@comet/cms-admin": minor
---

Add queryUpdatedAt helper that can be used in checkConflict without having the write an addtional query
8 changes: 0 additions & 8 deletions demo/admin/src/products/ProductForm.gql.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,14 +23,6 @@ export const productQuery = gql`
${productFormFragment}
`;

export const productCheckForChangesQuery = gql`
query CheckForChangesProduct($id: ID!) {
product(id: $id) {
updatedAt
}
}
`;

export const createProductMutation = gql`
mutation ProductFormCreateProduct($input: ProductInput!) {
createProduct(input: $input) {
Expand Down
15 changes: 4 additions & 11 deletions demo/admin/src/products/ProductForm.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,9 @@ import {
} from "@comet/admin";
import { ArrowLeft } from "@comet/admin-icons";
import { BlockState, createFinalFormBlock } from "@comet/blocks-admin";
import { DamImageBlock, EditPageLayout, resolveHasSaveConflict, useFormSaveConflict } from "@comet/cms-admin";
import { DamImageBlock, EditPageLayout, queryUpdatedAt, resolveHasSaveConflict, useFormSaveConflict } from "@comet/cms-admin";
import { CircularProgress, FormControlLabel, IconButton, MenuItem } from "@mui/material";
import {
GQLCheckForChangesProductQuery,
GQLCheckForChangesProductQueryVariables,
GQLProductFormCreateProductMutation,
GQLProductFormCreateProductMutationVariables,
GQLProductFormFragment,
Expand All @@ -39,7 +37,7 @@ import isEqual from "lodash.isequal";
import React from "react";
import { FormattedMessage } from "react-intl";

import { createProductMutation, productCheckForChangesQuery, productFormFragment, productQuery, updateProductMutation } from "./ProductForm.gql";
import { createProductMutation, productFormFragment, productQuery, updateProductMutation } from "./ProductForm.gql";

interface FormProps {
id?: string;
Expand Down Expand Up @@ -80,13 +78,8 @@ function ProductForm({ id }: FormProps): React.ReactElement {

const saveConflict = useFormSaveConflict({
checkConflict: async () => {
if (!id) return false;
const { data: hasConflictData } = await client.query<GQLCheckForChangesProductQuery, GQLCheckForChangesProductQueryVariables>({
query: productCheckForChangesQuery,
variables: { id },
fetchPolicy: "no-cache",
});
return resolveHasSaveConflict(data?.product.updatedAt, hasConflictData.product.updatedAt);
const updatedAt = await queryUpdatedAt(client, "product", id);
return resolveHasSaveConflict(data?.product.updatedAt, updatedAt);
},
formApiRef,
loadLatestVersion: async () => {
Expand Down
20 changes: 20 additions & 0 deletions packages/admin/cms-admin/src/form/queryUpdatedAt.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
import { ApolloClient } from "@apollo/client";
import gql from "graphql-tag";

export async function queryUpdatedAt(client: ApolloClient<object>, rootQueryName: string, id: string | undefined): Promise<string | undefined> {
if (!id) return undefined;

const query = gql`
query ($id: ID!) {
${rootQueryName}(id: $id) {
updatedAt
}
}
`;
const { data } = await client.query({
query,
variables: { id },
fetchPolicy: "no-cache",
});
return data[rootQueryName]?.updatedAt;
}
1 change: 1 addition & 0 deletions packages/admin/cms-admin/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ export type { DocumentInterface, DocumentType, IdsMap } from "./documents/types"
export { ChooseFileDialog } from "./form/file/chooseFile/ChooseFileDialog";
export { FileField } from "./form/file/FileField";
export { FinalFormToggleButtonGroup } from "./form/FinalFormToggleButtonGroup";
export { queryUpdatedAt } from "./form/queryUpdatedAt";
export { serializeInitialValues } from "./form/serializeInitialValues";
export { SyncFields } from "./form/SyncFields";
export { useFormSaveConflict } from "./form/useFormSaveConflict";
Expand Down

0 comments on commit adb5bc3

Please sign in to comment.