-
Notifications
You must be signed in to change notification settings - Fork 8
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Prevent invalid height value of MainContent when using the `fullHeigh…
…t` prop Previously, `topPosition` could be `undefined`, causing the `height` to be invalid because `calc()` contained the value `undefinedpx`. This issue would occur on the page tree when clicking on a page and then clicking the back button. The page tree's `MainContent` would have a height of `0`.
- Loading branch information
1 parent
028462c
commit 662abcc
Showing
2 changed files
with
8 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
--- | ||
"@comet/admin": patch | ||
--- | ||
|
||
Prevent the `MainContent` component from having an invalid height. | ||
|
||
This bug would cause the page tree to have no height when navigating into a page and then navigating back again. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters