Fix Jaeger tracing #311
Merged
Fix Jaeger tracing #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auto-assign
bot
requested review from
dkarnutsch,
fraxachun,
johnnyomair,
nsams and
thomasdax98
dkarnutsch
changed the title
chernylu
changed the title
chernylu
force-pushed
the
pin-jaeger-image
branch
from
a04c021
to
23f7290
Compare
johnnyomair
changed the title
johnnyomair
previously approved these changes
Jul 25, 2024
dkarnutsch
previously approved these changes
Jul 25, 2024
nsams
previously approved these changes
Jul 25, 2024
@chernylu could you please try if it still works when removing the respective variable? |
chernylu
dismissed stale reviews from nsams, dkarnutsch, and johnnyomair
via
8447361
johnnyomair
approved these changes
Jul 29, 2024
dkarnutsch
approved these changes
Jul 29, 2024
nsams
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a recent change in the OpenTelemetry Collector, Jaeger didn't accept OpenTelemetry data anymore. Until this change is reverted upstream, we explicitly pass the the host IP to Jaeger as a workaround. See jaegertracing/jaeger#5737 for more information.