increase go routine count when timepout happens

rateLimiter.go

@@ -37,13 +37,14 @@ func (l *Limiter) Wait() {
 	if l.timeout != nil {
 		select {
 		case <-ch:
-		case <-time.After((time.Duration(*l.timeout) * time.Second)):
+		case <-time.After((time.Duration(*l.timeout) * time.Millisecond)):
 			l.mu.Lock()
 			for w := l.waitList.Front(); w != nil; w = w.Next() {
 				ele := w.Value.(waiter)
 				if ele.done == ch {
 					close(ch)
 					l.waitList.Remove(w)
+					l.count += 1
 					break
 				}
 			}
@@ -74,7 +75,6 @@ func (l *Limiter) Finish() {
 	l.mu.Lock()
 	defer l.mu.Unlock()
 	l.count -= 1
-	l.count = max(0, l.count)
 	first := l.waitList.Front()
 	if first == nil {
 		return
@@ -83,10 +83,3 @@ func (l *Limiter) Finish() {
 	w.done <- struct{}{}
 	close(w.done)
 }
-
-func max(a, b int) int {
-	if a >= b {
-		return a
-	}
-	return b
-}

rateLimiter_test.go

@@ -47,7 +47,7 @@ func TestConcurrentRateLimiterBlocking(t *testing.T) {
 }
 
 func TestConcurrentRateLimiterTimeout(t *testing.T) {
-	l := NewLimiter(2).WithTimeout(2)
+	l := NewLimiter(2).WithTimeout(300)
 
 	var wg sync.WaitGroup
 	wg.Add(5)
@@ -58,9 +58,10 @@ func TestConcurrentRateLimiterTimeout(t *testing.T) {
 			l.Wait()
 		}()
 	}
-	time.Sleep(3 * time.Second)
+	time.Sleep(500 * time.Millisecond)
 	wg.Wait()
 	l.Finish()
 	l.Finish()
+	assert.Equal(t, 3, l.count)
 	assert.Equal(t, 0, l.waitList.Len())
 }