translate bone params category and tooltip in json renderer #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Lets wait with this one. I18N is still work in progess; the idea is that tr() will return an object instead of an translated string - so we'll have to resolve that object instead of calling translate again. |
@tsteinruecken What about this PR now? How can we translate them? |
sveneberth
requested review from
phorward,
skoegl,
akelch,
xnopasaranx and
tsteinruecken
and removed request for
tsteinruecken
tsteinruecken
added a commit
that referenced
this pull request
Feb 25, 2021
This allows translations to be used anywhere (bone-descriptions; it's params; in values for selectBones etc). Replaces #15
|
Replaced by #202 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: viur-framework/server#180