This repository has been archived by the owner on Sep 29, 2023. It is now read-only.
Correctly call bound PeriodicTask functions #190
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I wondered why my parameter "kinds" in this PeriodicTask-decorated function of my backup-module always contained the module's instance instead of the expected None value:
So I found out that the "bound method calling" in tasks.py is incorrect, so this fix should be better. Most PeriodicTask used in our projects do just throw away any parameter with *args, **kwargs, but here this isn't the case.