Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making MetadataAccessSpec optional again #302

Merged
merged 6 commits into from
May 13, 2022

Conversation

silvanheller
Copy link
Member

No description provided.

@silvanheller silvanheller requested a review from Spiess May 13, 2022 11:31
@silvanheller silvanheller self-assigned this May 13, 2022
@sauterl sauterl self-requested a review May 13, 2022 11:41
Copy link
Collaborator

@sauterl sauterl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am confused, the PR mentions MetadataAccessSpec but the only changes are related to the messageType.

Are there commits missing?

sauterl
sauterl previously approved these changes May 13, 2022
Copy link
Collaborator

@sauterl sauterl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work. LGTM

Spiess
Spiess previously approved these changes May 13, 2022
@silvanheller silvanheller dismissed stale reviews from Spiess and sauterl via 32f70d2 May 13, 2022 11:55
@silvanheller silvanheller merged commit b2fe84e into master May 13, 2022
@silvanheller silvanheller deleted the md-access-spec-optional branch May 13, 2022 11:57
silvanheller added a commit that referenced this pull request Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants