Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apply enable_public_net_ipv4 and enable_public_net_ipv6 to autoscaler configuration #381

Merged
merged 1 commit into from
Jul 24, 2024
Merged

apply enable_public_net_ipv4 and enable_public_net_ipv6 to autoscaler configuration #381

merged 1 commit into from
Jul 24, 2024

Conversation

Funzinator
Copy link
Contributor

fixes #372

vitobotta
vitobotta requested changes Jul 20, 2024
View reviewed changes
Copy link
Owner

@vitobotta vitobotta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thanks a lot. See comment - if you can test that change it would be great :)

src/kubernetes/software/cluster_autoscaler.cr Outdated Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 24, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@Funzinator
Copy link
Contributor Author

Funzinator commented Jul 24, 2024 •
edited
Loading

@vitobotta Ah, learned something new about Crystal :-)...
That works equally well. Amended my commit.

@vitobotta vitobotta merged commit 18700ad into vitobotta:main Jul 24, 2024
1 check passed
@vitobotta
Copy link
Owner

Thanks!

@vitobotta
Copy link
Owner

I also merged it into the v2 branch as well :)

@benkrej
Copy link

benkrej commented Jul 24, 2024

Thank you for fixing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vitobotta vitobotta vitobotta requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

disable public ipv4 / ipv6 ignored on autoscaled nodes
3 participants
@Funzinator @vitobotta @benkrej