Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: respect ssr.resolve.conditions on ssr environment #6993

Closed
wants to merge 2 commits into from

Conversation

sxzz
Copy link
Contributor

@sxzz sxzz commented Nov 30, 2024

Description

Respect resolve.conditions for ssr env.

closes #6992

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@sxzz sxzz changed the title fix: custom resolver conditions on ssr environment fix: respect resolve.conditions on ssr environment Nov 30, 2024
@sheremet-va
Copy link
Member

As I said in #6992 (comment) this is expected breaking change in Vite

Copy link

netlify bot commented Nov 30, 2024

Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 02af5d7
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/674b97b8eb085c0008dd605b
😎 Deploy Preview https://deploy-preview-6993--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sxzz sxzz changed the title fix: respect resolve.conditions on ssr environment fix: respect ssr.resolve.conditions on ssr environment Nov 30, 2024
@sxzz
Copy link
Contributor Author

sxzz commented Nov 30, 2024

@sheremet-va I just updated it to ssr.resolve.conditions.

@hi-ogawa
Copy link
Contributor

Closing since this compat is implemented by Vite vitejs/vite#18857

@hi-ogawa hi-ogawa closed this Dec 10, 2024
@sxzz sxzz deleted the fix/custom-resolver-conditions branch December 10, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't respect conditions on Vite 6
3 participants