Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(reporters): base reporter readability improvements #6889

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

AriPerkkio
Copy link
Member

Description

  • Improves readability of base reporter's code
  • While building other reporter related feature, I had to study base reporter throughly. The code wasn't easy to read so I did some improvements while looking into it. Let's merge these improvements here as their own PR in order to reduce changes of the actual up-coming feature PR.

"Readability" is opinionated term so feel free to suggest changes if some lines don't make sense.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

Copy link

netlify bot commented Nov 10, 2024

Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit a3bf04b
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/67307eccc970230008710492
😎 Deploy Preview https://deploy-preview-6889--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@AriPerkkio AriPerkkio force-pushed the refactor/base-reporter branch 3 times, most recently from 4eca21a to 178962f Compare November 10, 2024 09:51
sheremet-va
sheremet-va previously approved these changes Nov 10, 2024
packages/vitest/src/node/logger.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@hi-ogawa hi-ogawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@AriPerkkio AriPerkkio merged commit 00ebea6 into vitest-dev:main Nov 11, 2024
16 of 17 checks passed
@AriPerkkio AriPerkkio deleted the refactor/base-reporter branch November 11, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants