Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(browser): not.toBeInTheDocument works with locators API #6634

Conversation

sheremet-va
Copy link
Member

@sheremet-va sheremet-va commented Oct 3, 2024

Description

Related #6560

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

Copy link

netlify bot commented Oct 3, 2024

Deploy Preview for vitest-dev ready!

Name Link
🔨 Latest commit 10e081a
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/66feaa04743fa20008faa38d
😎 Deploy Preview https://deploy-preview-6634--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@hi-ogawa hi-ogawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chai flag approach is very clever, but is it necessary to support this use case?
From the discussion #6560, I feel it would also make sense to emphasize the difference between element and query like jest-dom instead of special casing toBeInTheDocument.

I'm sure if I'm missing some nuance, but by discussion OP's argument, I would be probably equally surprised if this happens:

// this pass
await expect.element(page.getByText('empty')).not.toBeInTheDocument()

// but this throws
await expect.element(page.getByText('empty')).not.toBeVisible()

Clarifying expect.element's behavior and being consistent sounds better to me to confusion.

@sheremet-va
Copy link
Member Author

sheremet-va commented Oct 4, 2024

Clarifying expect.element's behavior and being consistent sounds better to me to confusion.

Even if we just clarify how it works, there is no way to assert that the element is not in the DOM with expect.element.

not.toBeInTheDocument is a known convention in testing-library, so that's why I am prioritizing it here

await expect.element(page.getByText('empty')).not.toBeVisible()

This is a bit of a different story because it requires the change to the query itself, not the the way we retrieve the element:

- await expect.element(page.getByText('empty')).not.toBeVisible()
+ await expect.element(page.getByText('empty', { force: true })).not.toBeVisible()

So this would require a different change to work if we want to have a built-in support.

Copy link
Contributor

@hi-ogawa hi-ogawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even if we just clarify how it works, there is no way to assert that the element is not in the DOM with expect.element.

not.toBeInTheDocument is a known convention in testing-library, so that's why I am prioritizing it here

Okay, sounds good. expect.element expecting Element seemed simpler mental model, but I guess it's worth having this.

@sheremet-va sheremet-va merged commit 8bef5d2 into vitest-dev:main Oct 7, 2024
17 checks passed
@sheremet-va sheremet-va deleted the fix/element-not-to-be-in-the-document branch October 7, 2024 08:25
renovate bot added a commit to mmkal/eslint-plugin-mmkal that referenced this pull request Oct 14, 2024
##### [v2.1.3](https://github.com/vitest-dev/vitest/releases/tag/v2.1.3)

#####    🐞 Bug Fixes

-   Fix error diff of `toBeNaN, toBeUndefined, toBeNull, toBeTruthy, toBeFalsy`  -  by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#6697 [<samp>(e0027)</samp>](vitest-dev/vitest@e002758c)
-   **browser**:
    -   Provide aria role intellisense  -  by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#6629 [<samp>(f36ea)</samp>](vitest-dev/vitest@f36eac77)
    -   Not.toBeInTheDocument works with locators API  -  by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#6634 [<samp>(8bef5)</samp>](vitest-dev/vitest@8bef5d2b)
    -   Use `/mockServiceWorker.js` instead of `/__vitest_msw__`  -  by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#6687 [<samp>(4b2ce)</samp>](vitest-dev/vitest@4b2ce07f)
    -   Don't override the esbuild option in the browser mode  -  by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#6692 [<samp>(d131f)</samp>](vitest-dev/vitest@d131fd64)
-   **expect**:
    -   Preserve prototype in `toMatchObject` diff  -  by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#6620 [<samp>(d289e)</samp>](vitest-dev/vitest@d289e7eb)
-   **mocker**:
    -   Specify correct spy dependency  -  by [@sheremet-va](https://github.com/sheremet-va) [<samp>(7e958)</samp>](vitest-dev/vitest@7e9584aa)
-   **runner**:
    -   Ensure sequential suite overrides sequence.concurrent  -  by [@dsyddall](https://github.com/dsyddall) and [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#6653 [<samp>(5e6de)</samp>](vitest-dev/vitest@5e6de274)
-   **vitest**:
    -   Deprecate UserConfig in favor of ViteUserConfig  -  by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#6626 [<samp>(496bd)</samp>](vitest-dev/vitest@496bd251)
    -   Don't hang with maxConcurrency 0  -  by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#6627 [<samp>(946d8)</samp>](vitest-dev/vitest@946d8bb1)
    -   Deprecate old task types and node-reliant types  -  by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#6632 [<samp>(00045)</samp>](vitest-dev/vitest@000459a9)
    -   Fix `<empty line>` logs when interleaving `console.log/error`  -  by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#6644 [<samp>(9ece3)</samp>](vitest-dev/vitest@9ece3952)
    -   Show rollup error details as test error  -  by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#6686 [<samp>(47dde)</samp>](vitest-dev/vitest@47dde76f)
    -   Always inline setup files  -  by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#6689 [<samp>(19d64)</samp>](vitest-dev/vitest@19d64e20)
    -   Use `fast-glob` instead of `tinyglobby` in Vitest  -  by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#6688 [<samp>(70baa)</samp>](vitest-dev/vitest@70baaaa9)
-   **web-worker**:
    -   Share mocker with main executor  -  by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#6623 [<samp>(fe7b8)</samp>](vitest-dev/vitest@fe7b8aee)

#####    🏎 Performance

-   Reuse full name in reported tasks, update generator types  -  by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#6666 [<samp>(7a0de)</samp>](vitest-dev/vitest@7a0de0a7)

#####     [View changes on GitHub](vitest-dev/vitest@v2.1.2...v2.1.3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants