fix(workspace): fix glob pattern detection #6502

hi-ogawa · 2024-09-13T23:09:03Z

Description

closes Regression: Can no longer exclude folder from workspace #6499

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
Ideally, include a test that fails without this PR but passes with it.
Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

Run the tests with pnpm test:ci.

Documentation

If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

hi-ogawa · 2024-09-14T09:12:22Z

packages/vitest/src/node/workspace/resolveWorkspace.ts

@@ -158,7 +158,7 @@ async function resolveWorkspaceProjectConfigs(
      const stringOption = definition.replace('<rootDir>', vitest.config.root)
      // if the string doesn't contain a glob, we can resolve it directly
      // ['./vitest.config.js']
-      if (!stringOption.includes('*')) {
+      if (!stringOption.includes('*') && !stringOption.startsWith('!')) {


This should probably use isDynamicPattern from fast-glob https://github.com/mrmlnc/fast-glob?tab=readme-ov-file#isdynamicpatternpattern-options, but it looks like it's not supported yet on tinyglobby SuperchupuDev/tinyglobby#28

Can we copy paste it maybe? Other cases includes {} for example

Sounds good to me. I copied isDynamicPattern from fast-glob.

timbo-dev · 2024-09-16T10:23:38Z

Any predictions for the conclusion of this problem?

SuperchupuDev · 2024-09-30T15:18:45Z

hi @hi-ogawa! i saw isDynamicPattern mentioned here, and i just wanted to let you know that today's tinyglobby release added support for it, meaning you don't need to copy the implementation from fast-glob anymore :-)

@hi-ogawa

##### [v2.1.2](https://github.com/vitest-dev/vitest/releases/tag/v2.1.2) ##### 🐞 Bug Fixes - Move `Vitest.setServer` to post `configureServer` hook to enable import analysis for workspace config loading - by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#6584 [<samp>(e7f35)</samp>](vitest-dev/vitest@e7f35214) - **benchmark**: - Clear `BenchmarkResult.samples` array to reduce memory usage - by [@hi-ogawa](https://github.com/hi-ogawa) and [@AriPerkkio](https://github.com/AriPerkkio) in vitest-dev/vitest#6541 [<samp>(a6407)</samp>](vitest-dev/vitest@a6407afc) - **browser**: - Fix dynamic import inside worker - by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#6569 [<samp>(ea2d4)</samp>](vitest-dev/vitest@ea2d429b) - Fix browser mock factory event race condition - by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#6530 [<samp>(f131f)</samp>](vitest-dev/vitest@f131f93b) - Serve ui assets as static - by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#6564 [<samp>(adcda)</samp>](vitest-dev/vitest@adcdaee8) - Update solidjs testing library lib - by [@CamilleTeruel](https://github.com/CamilleTeruel) in vitest-dev/vitest#6548 [<samp>(91442)</samp>](vitest-dev/vitest@91442dfc) - Use `data:` protocol on preview provider file upload - by [@userquin](https://github.com/userquin) in vitest-dev/vitest#6501 [<samp>(e9821)</samp>](vitest-dev/vitest@e9821f70) - Fix base for client script - by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#6510 [<samp>(f9528)</samp>](vitest-dev/vitest@f952874e) - Throw an error if "@vitest/browser/context" is imported outside of the browser mode - by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#6570 [<samp>(383f1)</samp>](vitest-dev/vitest@383f1791) - **coverage**: - Remove empty coverage folder on test failure too - by [@AriPerkkio](https://github.com/AriPerkkio) in vitest-dev/vitest#6547 [<samp>(1371c)</samp>](vitest-dev/vitest@1371ca6a) - Include `*.astro` by default - by [@AriPerkkio](https://github.com/AriPerkkio) in vitest-dev/vitest#6565 [<samp>(f8ff7)</samp>](vitest-dev/vitest@f8ff76a9) - `cleanOnRerun: false` to invalidate previous results - by [@AriPerkkio](https://github.com/AriPerkkio) in vitest-dev/vitest#6592 [<samp>(88bde)</samp>](vitest-dev/vitest@88bde99c) - **expect**: - Fix `toBeDefined` with `expect.poll` - by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#6562 [<samp>(f7da6)</samp>](vitest-dev/vitest@f7da6199) - **runner**: - Mark tests as skipped when `beforeAll` failed - by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#6524 [<samp>(fb797)</samp>](vitest-dev/vitest@fb79792d) - Support fixture parsing of lowered async syntax - by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#6531 [<samp>(b553c)</samp>](vitest-dev/vitest@b553c7d6) - Fix fixture parsing of lowered async syntax for non arrow functions - by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#6575 [<samp>(3de00)</samp>](vitest-dev/vitest@3de00ab6) - Guard test hook callback - by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#6604 [<samp>(14971)</samp>](vitest-dev/vitest@1497134e) - Run `onTestFinished` and `onTestFailed` during `retry` and `repeats` - by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#6609 [<samp>(c5e29)</samp>](vitest-dev/vitest@c5e29098) - **ui**: - List tests on ui when `--standalone` - by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#6577 [<samp>(d0bf8)</samp>](vitest-dev/vitest@d0bf89d3) - **vite-node**: - Fix esm false-detection inside comment - by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#6506 [<samp>(91f85)</samp>](vitest-dev/vitest@91f85997) - **vitest**: - Install dependencies with the same version when prompted - by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#6611 [<samp>(ed8b7)</samp>](vitest-dev/vitest@ed8b7c08) - Make env.SSR consistent between different pools - by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#6616 [<samp>(8a8d3)</samp>](vitest-dev/vitest@8a8d3f03) - Don't start a websocket server if api is disabled - by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#6617 [<samp>(82140)</samp>](vitest-dev/vitest@821400b8) - **workspace**: - Fix glob pattern detection - by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#6502 [<samp>(7727c)</samp>](vitest-dev/vitest@7727ca87) - Ignore DS_Store by default - by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#6571 [<samp>(d2a86)</samp>](vitest-dev/vitest@d2a86ff5) ##### [View changes on GitHub](vitest-dev/vitest@v2.1.1...v2.1.2)

fix(workspace): fix glob negation pattern

318747d

hi-ogawa marked this pull request as ready for review September 13, 2024 23:27

hi-ogawa commented Sep 14, 2024

View reviewed changes

hi-ogawa added 2 commits September 17, 2024 08:45

Merge branch 'main' into fix-workspace-negated-pattern

333698b

fix: use fast-glob's isDynamicPattern

e6189a1

hi-ogawa changed the title ~~fix(workspace): fix glob negation pattern~~ fix(workspace): fix glob pattern detection Sep 17, 2024

hi-ogawa added 2 commits September 17, 2024 09:30

chore: cleanup

4adca94

chore: license

13ea69e

sheremet-va approved these changes Sep 25, 2024

View reviewed changes

sheremet-va merged commit 7727ca8 into vitest-dev:main Sep 25, 2024
14 of 16 checks passed

hi-ogawa deleted the fix-workspace-negated-pattern branch September 30, 2024 22:55

hi-ogawa mentioned this pull request Oct 1, 2024

chore(deps): update tinyglobby and use isDynamicPattern #6600

Draft

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(workspace): fix glob pattern detection #6502

fix(workspace): fix glob pattern detection #6502

hi-ogawa commented Sep 13, 2024 •

edited

Loading

hi-ogawa Sep 14, 2024

sheremet-va Sep 16, 2024

hi-ogawa Sep 17, 2024

timbo-dev commented Sep 16, 2024

SuperchupuDev commented Sep 30, 2024

fix(workspace): fix glob pattern detection #6502

fix(workspace): fix glob pattern detection #6502

Conversation

hi-ogawa commented Sep 13, 2024 • edited Loading

Description

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

Tests

Documentation

Changesets

hi-ogawa Sep 14, 2024

Choose a reason for hiding this comment

sheremet-va Sep 16, 2024

Choose a reason for hiding this comment

hi-ogawa Sep 17, 2024

Choose a reason for hiding this comment

timbo-dev commented Sep 16, 2024

SuperchupuDev commented Sep 30, 2024

hi-ogawa commented Sep 13, 2024 •

edited

Loading