Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix flaky slowTestThreshold test #5130

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

hi-ogawa
Copy link
Contributor

@hi-ogawa hi-ogawa commented Feb 7, 2024

Description

On CI, it sometimes happens that the "fast" one (10 ms) is taking over slowTestThreshold (100 ms) possibly due to a heavy cpu load.

https://github.com/vitest-dev/vitest/actions/runs/7808613959/job/21299124920?pr=5093#step:8:811

I tweaked some numbers so that hopefully it will be less flaky.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

Copy link

netlify bot commented Feb 7, 2024

Deploy Preview for fastidious-cascaron-4ded94 canceled.

Name Link
🔨 Latest commit 9b5a6f3
🔍 Latest deploy log https://app.netlify.com/sites/fastidious-cascaron-4ded94/deploys/65c2f26ae2f2a200073aa11c

@hi-ogawa hi-ogawa changed the title test: fix flaky slowTestThreshold test test: fix flaky slowTestThreshold test Feb 7, 2024
@hi-ogawa hi-ogawa marked this pull request as ready for review February 7, 2024 08:34
@sheremet-va sheremet-va merged commit 2085131 into vitest-dev:main Feb 7, 2024
17 of 19 checks passed
@hi-ogawa hi-ogawa deleted the test-flaky-slowTestThreshold branch February 8, 2024 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants