-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add css
config option, don't process CSS by default
#1467
Conversation
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
packages/vitest/src/types/config.ts
Outdated
* | ||
* @default [/\.module\./] | ||
*/ | ||
processCss?: boolean | RegExp[] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a great DX improvement. About naming, given that there is already a css
option in Vite, maybe this new option could be aligned with it:
css: {
include: RegExp | RegExp[], // @default [/\.module\./]
exclude: RegExp | RegExp[]
}
Removing the process
in the name could be helpful if there are other CSS options added later. Or maybe css: boolean | { include, exclude }
if you still want users to use css: true
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think if we want to add more features to css, they should be added to Vite’s options :)
About the object - I think yes, we can align it with other similar options.
css
config option, don't process CSS by default
Co-authored-by: Bartosz Gościński <bargosc@gmail.com>
… feat/process-css
No description provided.