Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI documentation for --pool option is incorrect for default value #7035

Closed
6 tasks done
austinhnelson opened this issue Dec 5, 2024 · 1 comment · Fixed by #7038
Closed
6 tasks done

CLI documentation for --pool option is incorrect for default value #7035

austinhnelson opened this issue Dec 5, 2024 · 1 comment · Fixed by #7038
Labels
documentation Improvements or additions to documentation pr welcome

Comments

@austinhnelson
Copy link
Contributor

Describe the bug

The description for the --pool option in the cli documentation is not correct for the default value. The default value used to be threads but was updated to forks in 2.0: https://vitest.dev/guide/migration.html

Reproduction

https://vitest.dev/guide/cli.html#pool

System Info

Standard browser

Used Package Manager

npm

Validations

@AriPerkkio AriPerkkio added documentation Improvements or additions to documentation pr welcome and removed pending triage labels Dec 5, 2024
@AriPerkkio
Copy link
Member

PR welcome:

### pool
- **CLI:** `--pool <pool>`
- **Config:** [pool](/config/#pool)
Specify pool, if not running in the browser (default: `threads`)

austinhnelson pushed a commit to austinhnelson/vitest that referenced this issue Dec 5, 2024
austinhnelson added a commit to austinhnelson/vitest that referenced this issue Dec 6, 2024
austinhnelson added a commit to austinhnelson/vitest that referenced this issue Dec 6, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Dec 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation pr welcome
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants