fix(runner): passWithNoTests option not work (#4553)

vitest-dev · Nov 28, 2023 · 8d183da · 8d183da
1 parent cb87f44
commit 8d183da
Show file tree

Hide file tree

Showing 6 changed files with 24 additions and 1 deletion.
diff --git a/packages/runner/src/run.ts b/packages/runner/src/run.ts
@@ -328,7 +328,7 @@ export async function runSuite(suite: Suite, runner: VitestRunner) {
     }
 
     if (suite.mode === 'run') {
-      if (!hasTests(suite)) {
+      if (!runner.config.passWithNoTests && !hasTests(suite)) {
         suite.result.state = 'fail'
         if (!suite.result.errors?.length) {
           const error = processError(new Error(`No test found in suite ${suite.name}`))

diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
diff --git a/test/empty-test/package.json b/test/empty-test/package.json
@@ -0,0 +1,11 @@
+{
+  "name": "@vitest/test-empty-test",
+  "type": "module",
+  "private": true,
+  "scripts": {
+    "test": "vitest run --passWithNoTests"
+  },
+  "devDependencies": {
+    "vitest": "workspace:*"
+  }
+}
diff --git a/test/empty-test/test/empty.test.ts b/test/empty-test/test/empty.test.ts
diff --git a/test/empty-test/test/one.test.ts b/test/empty-test/test/one.test.ts
@@ -0,0 +1,3 @@
+import { expect, test } from 'vitest'
+
+test('two', () => expect(1 + 1).toBe(2))
diff --git a/test/empty-test/vitest.config.ts b/test/empty-test/vitest.config.ts
@@ -0,0 +1,3 @@
+import { defineConfig } from 'vitest/config'
+
+export default defineConfig({})