Skip to content

Commit

Permalink
perf: use hash to replace createHash (#6703)
Browse files Browse the repository at this point in the history
  • Loading branch information
btea authored Oct 15, 2024
1 parent a61293e commit 5d07bba
Show file tree
Hide file tree
Showing 5 changed files with 15 additions and 8 deletions.
4 changes: 2 additions & 2 deletions packages/vitest/src/integrations/css/css-modules.ts
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import { createHash } from 'node:crypto'
import { hash } from '../../node/hash'
import type { CSSModuleScopeStrategy } from '../../node/types/config'

export function generateCssFilenameHash(filepath: string) {
return createHash('md5').update(filepath).digest('hex').slice(0, 6)
return hash('md5', filepath, 'hex').slice(0, 6)
}

export function generateScopedClassName(
Expand Down
4 changes: 2 additions & 2 deletions packages/vitest/src/node/cache/index.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import crypto from 'node:crypto'
import { resolve } from 'pathe'
import { slash } from '../../utils'
import { hash } from '../hash'
import { FilesStatsCache } from './files'
import { ResultsCache } from './results'

Expand All @@ -26,7 +26,7 @@ export class VitestCache {
? resolve(
root,
baseDir,
crypto.createHash('md5').update(projectName, 'utf-8').digest('hex'),
hash('md5', projectName, 'hex'),
)
: resolve(root, baseDir)
}
Expand Down
7 changes: 7 additions & 0 deletions packages/vitest/src/node/hash.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
import crypto from 'node:crypto'

export const hash = crypto.hash ?? ((
algorithm: string,
data: crypto.BinaryLike,
outputEncoding: crypto.BinaryToTextEncoding,
) => crypto.createHash(algorithm).update(data).digest(outputEncoding))
4 changes: 2 additions & 2 deletions packages/vitest/src/node/pools/rpc.ts
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
import { createHash } from 'node:crypto'
import { mkdir, writeFile } from 'node:fs/promises'
import type { RawSourceMap } from 'vite-node'
import { join } from 'pathe'
import type { WorkspaceProject } from '../workspace'
import type { RuntimeRPC } from '../../types/rpc'
import { hash } from '../hash'

const created = new Set()
const promises = new Map<string, Promise<void>>()
Expand Down Expand Up @@ -47,7 +47,7 @@ export function createMethodsRPC(project: WorkspaceProject, options: MethodsOpti
}

const dir = join(project.tmpDir, transformMode)
const name = createHash('sha1').update(id).digest('hex')
const name = hash('sha1', id, 'hex')
const tmp = join(dir, name)
if (promises.has(tmp)) {
await promises.get(tmp)
Expand Down
4 changes: 2 additions & 2 deletions packages/vitest/src/node/sequencers/BaseSequencer.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { createHash } from 'node:crypto'
import { relative, resolve } from 'pathe'
import { slash } from 'vite-node/utils'
import { hash } from '../hash'
import type { Vitest } from '../core'
import type { WorkspaceSpec } from '../pool'
import type { TestSequencer } from './types'
Expand All @@ -25,7 +25,7 @@ export class BaseSequencer implements TestSequencer {
const specPath = fullPath?.slice(config.root.length)
return {
spec,
hash: createHash('sha1').update(specPath).digest('hex'),
hash: hash('sha1', specPath, 'hex'),
}
})
.sort((a, b) => (a.hash < b.hash ? -1 : a.hash > b.hash ? 1 : 0))
Expand Down

0 comments on commit 5d07bba

Please sign in to comment.