Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor tsconfig for Stricter Type-Safe Settings #605

Merged
merged 3 commits into from
Dec 20, 2024

Conversation

y-hsgw
Copy link
Contributor

@y-hsgw y-hsgw commented Dec 19, 2024

I have made the following changes:

  • Fixed type errors in the test files.
  • Updated plugin.config. Reference: eslint-plugin-jest.

There may be some misunderstandings on my part, but I would appreciate your review.

Copy link
Member

@veritem veritem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we want to change anything in index.ts. there are a lot of differences in how types are handled in this package and in jest's

@veritem
Copy link
Member

veritem commented Dec 20, 2024

let's keep changes under test/ and revert everything else. also keep include test direction in tsconfig.json, I forgot to add it

@y-hsgw
Copy link
Contributor Author

y-hsgw commented Dec 20, 2024

I have reverted most of the changes in index.ts.
I decided to remove ESLint.Plugin as it caused type errors in rules and seemed inappropriate.

Copy link
Member

@veritem veritem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will investiage why types are mistmatching, it used to work!

@veritem veritem merged commit 949aaf7 into vitest-dev:main Dec 20, 2024
@y-hsgw y-hsgw deleted the fix/type-check branch December 20, 2024 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants