Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the vttestserver persistent mode #1484

Merged
merged 4 commits into from
Jun 28, 2023

Conversation

hkdsun
Copy link
Member

@hkdsun hkdsun commented May 24, 2023

Follow up to vitessio/vitess#13065

This adds some documentation around --persistent_mode of the vttestserver container. We've integrated this particular invocation of vttestserver into Shopify's development environments with successful results, even across developer laptop reboots, crashes, etc.

@netlify
Copy link

netlify bot commented May 29, 2023

Deploy Preview for vitess ready!

Name Link
🔨 Latest commit 9ce4a5e
🔍 Latest deploy log https://app.netlify.com/sites/vitess/deploys/649c4e5ff263bc00086c2cf2
😎 Deploy Preview https://deploy-preview-1484--vitess.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hkdsun hkdsun force-pushed the add-vttestserver-persistent-mode branch from 17f1892 to bfb29dc Compare May 29, 2023 18:44
@frouioui
Copy link
Member

Hello @hkdsun - Since we have released v17.0.0-rc1 we created a new documentation folder v18.0, can you please copy the documentation you wrote in this PR onto this new folder too?

@hkdsun hkdsun force-pushed the add-vttestserver-persistent-mode branch from bfb29dc to 39dae04 Compare June 26, 2023 18:13
hkdsun added 3 commits June 26, 2023 18:14
Signed-off-by: Hormoz Kheradmand <hormoz.kheradmand@shopify.com>
Signed-off-by: Hormoz Kheradmand <hormoz.kheradmand@shopify.com>
Signed-off-by: Hormoz Kheradmand <hormoz.kheradmand@shopify.com>
@hkdsun hkdsun force-pushed the add-vttestserver-persistent-mode branch from 39dae04 to f36adba Compare June 26, 2023 18:14
@hkdsun
Copy link
Member Author

hkdsun commented Jun 26, 2023

Hi @frouioui, I have copied the documentation over to v18.0.

Back to you 🙏

Copy link
Member

@frouioui frouioui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you 🚀

Signed-off-by: Hormoz Kheradmand <hormoz.kheradmand@shopify.com>
@frouioui frouioui merged commit c09493f into vitessio:prod Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants